Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Closed
3 tasks
OS-jacobbell
approved these changes
Aug 10, 2026
OS-jacobbell
left a comment
OS-jacobbell
left a comment
Contributor
There was a problem hiding this comment.
Looks good, great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31332
What is the current behavior?
Currently, pulling down inside a sheet or card modal dismisses the modal instead of triggering the refresher when the content uses a custom scroll host.
What is the new behavior?
With this change, the gesture resolves the refresher from the enclosing
ion-contentwhen the swipe target is a custom scroll host, so pulling down runs the refresher and leaves the modal alone. The newfindRefresherInContentutil only reports a refresher for the scroll host that refresher actually scrolls with, which is the first one in the content, so a second unrelated scroll host still swipes the modal normally. TheexpandToScroll: falsepath now runs the same check.Does this introduce a breaking change?
Other information
Test coverage is 4 e2e tests on the new page:
Test page (iOS)
Test page (MD)
Current dev build: